triform/chromeless
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(framesink): retarget running capturer on repeated start #34

Closed
triform-admin wants to merge 1 commit from codex/cv2-framesink-retarget-20260609 into codex/cv2-wave2-verification-20260522
pull from: codex/cv2-framesink-retarget-20260609
merge into: triform:codex/cv2-wave2-verification-20260522
Conversation 1 Commits 1 Files changed 3 +18 -8
triform-admin commented 2026-06-09 11:31:44 +00:00
Owner
Copy link

Implements the FrameSink retarget handoff for CV2 native WebRTC.\n\nScope:\n- CloudBrowserFrameSinkCapturer::Start now calls ChangeTarget on an already-running producer instead of returning.\n- Capturer API comment updated from idempotent/no-op to retarget semantics.\n- Existing repeated-Start unit test now asserts one producer Start and two ChangeTarget calls.\n\nValidation run here:\n- git diff --check\n- branch pushed: codex/cv2-framesink-retarget-20260609\n\nNote: I did not run the Chromium/Chromeless binary test suite locally; this checkout does not expose a lightweight local build harness and the fleet bake remains the next validation step.

Implements the FrameSink retarget handoff for CV2 native WebRTC.\n\nScope:\n- CloudBrowserFrameSinkCapturer::Start now calls ChangeTarget on an already-running producer instead of returning.\n- Capturer API comment updated from idempotent/no-op to retarget semantics.\n- Existing repeated-Start unit test now asserts one producer Start and two ChangeTarget calls.\n\nValidation run here:\n- git diff --check\n- branch pushed: codex/cv2-framesink-retarget-20260609\n\nNote: I did not run the Chromium/Chromeless binary test suite locally; this checkout does not expose a lightweight local build harness and the fleet bake remains the next validation step.
fix(framesink): retarget running capturer on repeated start
Some checks failed
CI / Lint (pull_request) Failing after 23s
Details
CI / Docs link check (pull_request) Failing after 2s
Details
CodeQL / Analyze go (pull_request) Failing after 2s
Details
CodeQL / Analyze javascript-typescript (pull_request) Failing after 3s
Details
CI / Build container image (pull_request) Failing after 42s
Details
CI / Container smoke test (pull_request) Has been skipped
Details
E2E / docker-compose + Playwright (pull_request) Failing after 30s
Details
native-peer-gate / Build chromeless:ci for gate (pull_request) Failing after 1m24s
Details
native-peer-gate / native-peer-gate-scaffold (permissive) (pull_request) Has been skipped
Details
native-peer-gate / native-peer-gate-strict (M7 gate) (pull_request) Has been skipped
Details
a1fc09634a
triform-admin closed this pull request 2026-07-30 02:56:06 +00:00
triform-admin commented 2026-07-30 02:56:23 +00:00
Author
Owner
Copy link

Closing: this PR targets the dead codex/cv2-wave2-verification-20260522 base branch. The retarget fix itself landed on main long ago via the wave-3 lineage (f0f4722 “framesink retarget resolution-constraint fix into wave-3”, merged in 6e37b31). Nothing here is lost.

Closing: this PR targets the dead `codex/cv2-wave2-verification-20260522` base branch. The retarget fix itself landed on main long ago via the wave-3 lineage (f0f4722 “framesink retarget resolution-constraint fix into wave-3”, merged in 6e37b31). Nothing here is lost.
Some checks failed
CI / Lint (pull_request) Failing after 23s
Details
CI / Docs link check (pull_request) Failing after 2s
Details
CodeQL / Analyze go (pull_request) Failing after 2s
Details
CodeQL / Analyze javascript-typescript (pull_request) Failing after 3s
Details
CI / Build container image (pull_request) Failing after 42s
Details
CI / Container smoke test (pull_request) Has been skipped
Details
E2E / docker-compose + Playwright (pull_request) Failing after 30s
Details
native-peer-gate / Build chromeless:ci for gate (pull_request) Failing after 1m24s
Details
native-peer-gate / native-peer-gate-scaffold (permissive) (pull_request) Has been skipped
Details
native-peer-gate / native-peer-gate-strict (M7 gate) (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
triform/chromeless!34
No description provided.