triform/cargoless
Template
1
0
Fork 0
Code Issues 1 Pull requests 12 Projects Releases Packages Wiki Activity Actions 7

fix(serve): honor diagnostic refreshes until deadline #143

Open
triform-admin wants to merge 4 commits from agent/diagnostic-retrigger-refresh-20260804 into main
pull from: agent/diagnostic-retrigger-refresh-20260804
merge into: triform:main
Conversation 0 Commits 4 Files changed 3 +44 -24
triform-admin commented 2026-08-04 06:15:27 +00:00
Owner
Copy link

Root cause: rust-analyzer can emit more than three refresh-backed ServerCancelled responses for a large multi-document overlay. The existing overall diagnostic transaction deadline already bounds retries, but the second fixed retry cap converted healthy refresh progress into indeterminate.contract.\n\nThis change retries retrigger=true cancellations only after each distinct diagnostic refresh and only until the existing deadline. The regression drives four refresh-backed cancellations before a successful report, exceeding the legacy cap.\n\nLocal cargo execution was intentionally not used because the shared-workspace safety hook prohibits it; Forgejo CI is the compile/test authority.

Root cause: rust-analyzer can emit more than three refresh-backed ServerCancelled responses for a large multi-document overlay. The existing overall diagnostic transaction deadline already bounds retries, but the second fixed retry cap converted healthy refresh progress into indeterminate.contract.\n\nThis change retries retrigger=true cancellations only after each distinct diagnostic refresh and only until the existing deadline. The regression drives four refresh-backed cancellations before a successful report, exceeding the legacy cap.\n\nLocal cargo execution was intentionally not used because the shared-workspace safety hook prohibits it; Forgejo CI is the compile/test authority.
fix(serve): honor diagnostic refreshes until deadline
Some checks failed
ci / rust-analyzer latency harness (S1 / AC#2) (pull_request) Has been skipped
Details
ci / build (pull_request) Successful in 2m6s
Details
ci / lane policy mutation proof (pull_request) Successful in 4m26s
Details
ci / clippy (pull_request) Successful in 9m6s
Details
ci / test (pull_request) Successful in 15m24s
Details
ci / fmt (pull_request) Failing after 18m23s
Details
96f6e5d6ea
fix(ci): isolate Cargoless validation lane
Some checks are pending
ci / build (pull_request) Waiting to run
Details
ci / test (pull_request) Waiting to run
Details
ci / lane policy mutation proof (pull_request) Waiting to run
Details
ci / fmt (pull_request) Waiting to run
Details
ci / clippy (pull_request) Waiting to run
Details
ci / rust-analyzer latency harness (S1 / AC#2) (pull_request) Waiting to run
Details
5312948584
fix(lane): make stale candidate cleanup idempotent
Some checks are pending
ci / build (pull_request) Waiting to run
Details
ci / test (pull_request) Waiting to run
Details
ci / lane policy mutation proof (pull_request) Waiting to run
Details
ci / fmt (pull_request) Waiting to run
Details
ci / clippy (pull_request) Waiting to run
Details
ci / rust-analyzer latency harness (S1 / AC#2) (pull_request) Waiting to run
Details
759fb668ed
Merge remote-tracking branch 'origin/main' into agent/diagnostic-retrigger-refresh-20260804
Some checks are pending
ci / build (pull_request) Waiting to run
Details
ci / test (pull_request) Waiting to run
Details
ci / lane policy mutation proof (pull_request) Waiting to run
Details
ci / fmt (pull_request) Waiting to run
Details
ci / clippy (pull_request) Waiting to run
Details
ci / rust-analyzer latency harness (S1 / AC#2) (pull_request) Waiting to run
Details
7c3803b509 
# Conflicts:
#	crates/cargoless-core/src/lanetree.rs
Some checks are pending
ci / build (pull_request) Waiting to run
Details
ci / test (pull_request) Waiting to run
Details
ci / lane policy mutation proof (pull_request) Waiting to run
Details
ci / fmt (pull_request) Waiting to run
Details
ci / clippy (pull_request) Waiting to run
Details
ci / rust-analyzer latency harness (S1 / AC#2) (pull_request) Waiting to run
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin agent/diagnostic-retrigger-refresh-20260804:agent/diagnostic-retrigger-refresh-20260804
git switch agent/diagnostic-retrigger-refresh-20260804

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff agent/diagnostic-retrigger-refresh-20260804
git switch agent/diagnostic-retrigger-refresh-20260804
git rebase main
git switch main
git merge --ff-only agent/diagnostic-retrigger-refresh-20260804
git switch agent/diagnostic-retrigger-refresh-20260804
git rebase main
git switch main
git merge --no-ff agent/diagnostic-retrigger-refresh-20260804
git switch main
git merge --squash agent/diagnostic-retrigger-refresh-20260804
git switch main
git merge --ff-only agent/diagnostic-retrigger-refresh-20260804
git switch main
git merge agent/diagnostic-retrigger-refresh-20260804
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
triform/cargoless!143
No description provided.