fix(build): restore unittest targets to the t7 lane (10-week silent skip) #45

Merged

triform-admin merged 3 commits from fix/t7-lane-restore-unittests into main 2026-07-30 06:29:09 +00:00

Conversation 0 Commits 3 Files changed 1 +15 -12

triform-admin commented 2026-07-30 04:01:02 +00:00

Owner

Copy link

The t7 job carried build-czar 2026-05-17 opt B (worker-only targets), a build-#23-era mitigation for compile errors in cloud_browser_pcf_test.cc. Those test TUs were repaired long ago (BUILD.gn Wall #37 test_support work) and every other lane kept building the encoder+framesink unittest binaries — but t7, the lane actually used for verification builds, has been skipping them for 10 weeks.

Surfaced 2026-07-30 by the first verify-loop build of main: the worker compiled clean in 11m15s, then STEP 7 failed exit-127 on both missing test binaries — chromeless-build.sh treats absent tests as FATAL (the CHROMELESS_TESTS_NONFATAL=1 and record why guard), which is exactly the honesty this lane was quietly defeating.

A rebuild with the targets restored is running now; this PR makes the lane definition durable. t2's extra pcf_unittests target stays t2-only.

🤖 Generated with Claude Code

The t7 job carried build-czar 2026-05-17 opt B (worker-only targets), a build-#23-era mitigation for compile errors in `cloud_browser_pcf_test.cc`. Those test TUs were repaired long ago (BUILD.gn Wall #37 test_support work) and every other lane kept building the encoder+framesink unittest binaries — but **t7, the lane actually used for verification builds, has been skipping them for 10 weeks**. Surfaced 2026-07-30 by the first verify-loop build of main: the worker compiled clean in 11m15s, then STEP 7 failed exit-127 on both missing test binaries — `chromeless-build.sh` treats absent tests as FATAL (the `CHROMELESS_TESTS_NONFATAL=1 and record why` guard), which is exactly the honesty this lane was quietly defeating. A rebuild with the targets restored is running now; this PR makes the lane definition durable. t2's extra pcf_unittests target stays t2-only. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

triform-admin added 1 commit 2026-07-30 04:01:02 +00:00

fix(build): restore unittest targets to the t7 lane (10-week silent skip) ... 16b24b6ba7

The t7 job carried build-czar 2026-05-17 opt B (worker-only targets), a
build-#23-era mitigation for compile errors in cloud_browser_pcf_test.cc.
Those test TUs were repaired long ago (BUILD.gn Wall #37 test_support
work) and every other lane kept building the encoder+framesink unittest
binaries — but t7, the lane actually used for verification builds, has
been skipping them for 10 weeks.

Surfaced 2026-07-30 by the first verify-loop build of main: the worker
compiled clean in 11m15s, then STEP 7 failed exit-127 on both missing
test binaries — chromeless-build.sh treats absent tests as FATAL (the
'set CHROMELESS_TESTS_NONFATAL=1 and record why' guard), which is
exactly the honesty this lane was quietly defeating.

t2's extra pcf_unittests target stays t2-only for now.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

triform-admin added 1 commit 2026-07-30 04:49:36 +00:00

ci: re-run — Lint's runner dind restarted mid-job (dind-gc fleet rollout 04:04-04:37Z) 5ef7085374

triform-admin referenced this pull request from a commit 2026-07-30 05:12:26 +00:00

fix(build): the c12d40d rename severed the profile pipe — every image since 2026-05-05 built profile=sw

triform-admin referenced this pull request 2026-07-30 05:12:39 +00:00

fix(build): c12d40d rename severed the profile pipe — every image since 2026-05-05 built profile=sw #46

triform-admin added 1 commit 2026-07-30 05:48:39 +00:00

ci: re-run — docs-check runner's dind died mid-pull (fleet rollout tail) 87cebf03fb

triform-admin merged commit 2f11285114 into main 2026-07-30 06:29:09 +00:00

triform-admin referenced this pull request from a commit 2026-07-30 06:29:19 +00:00

Merge pull request 'fix(build): restore unittest targets to the t7 lane (10-week silent skip)' (#45) from fix/t7-lane-restore-unittests into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

triform/chromeless!45

No description provided.